Comments on: DOMPDF + justification + extended ASCII chars

By: Álvaro

Álvaro — Thu, 08 Jul 2010 18:27:01 +0000

Hi,
I’m not sure if this is the same problem related with this post, but here it goes:
- Words inside table cells and/or divs are splited the wrong way… For exemple… at the end of the line a word like ‘computer’ is splitted com (line break here)
puted.
I’m using domPDF 0.5.1.
Any help would be appreciated.
Thanxs in advance
Álvaro

P.S. – I can send an url that create a PDF with this errors as well.

By: Albert

Albert — Mon, 21 Jun 2010 07:53:48 +0000

With the version 0.6 and windows there is solved the problem of the loss of lines by the following change

text_frame_reflower.cls.php line 153 $offset = strlen($str);

By: Albert

Albert — Thu, 10 Jun 2010 19:36:24 +0000

Hello. Luca.
I am using dompdf with the library CPDF with the modifications that you propose. It works well, but I meet a serious problem. If the last character of the line is a special, the following lines of the paragraph disappear.
Can you help me to find a solution?
With this failure, dompdf is not valid since the lines disappear in a random way.
Thank you very much.

By: Mike

Mike — Wed, 21 Apr 2010 21:13:46 +0000

in fact this is slightly better

if ($frame->get_node()->nodeName == “#text”)
$text = trim($frame->get_text());
$this->_lines[$this->_cl]["wc"] = count(preg_split(“/\s+/”, $text ));
$this->_lines[$this->_cl]["w"] += $w;

if (substr($text, -1) != “-” && substr($text, -1) != “.” ){
$this->_lines[$this->_cl]["justify"] = -2;
}

and then

$spacing = ($width – ($line["w"] + $line["justify"])) / ($line["wc"] -1);

(to sort out line breaks and fullstops.

By: Mike

Mike — Wed, 21 Apr 2010 21:10:05 +0000

ok add something like this

if (substr($text, -1) == “-” || substr($text, -1) == “.” ){
$this->_lines[$this->_cl]["wc"] += 1;
}else{
$this->_lines[$this->_cl]["justify"] = -2;
}

block_frame_decorator.cls.php on lne 192

AND

add this
$spacing = ($width – ($line["w"] + $line["justify"])) / ($line["wc"] -2);

to block_frame_reflower.cls.php line 431.

basically the maths is wrong for it. It hasn’t accounted for the extra white spaces on each line that occur.

they will be a tidy way of doing this and it probably involves trimming the white spaces for each line but this highlghts the problem

By: Mike

Mike — Wed, 21 Apr 2010 20:49:28 +0000

I have found the solution , there are some issues in the way the code generates the spacing for each line. It will only work for the first and last line, not the rest. . will explain when get this working

By: Mike

Mike — Wed, 21 Apr 2010 19:24:08 +0000

well I have made the string replacement but can’t find it on page.cache and then added the static diff array to the top of the cpdf_adapter.cls.php but it makes no difference the right side just isn’t aligning correctly when I justify it. Each line is somewhere between 0 and 10 pixels out.

Its not much i know but you can really notice it.

By: Luca Priorelli

Luca Priorelli — Wed, 21 Apr 2010 16:02:00 +0000

@mike – If you provide an example I can use it to test it with the latest code. I have also done some work to make DOMPDF work with another PDF library (TCPDF) and I would like to see how well it works.

By: Mike

Mike — Wed, 21 Apr 2010 15:32:51 +0000

I cant get this work either, done everything above but still no joy (version 0.5.1)

By: Maicon

Maicon — Wed, 10 Mar 2010 17:45:50 +0000

yes very good